linux-kernel - Re: [PATCH v2 -next] ACPI/IORT: Fix build error implicit-function-declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc4ec60d-3abf-efd9-6536-cec24c6b19ef@huawei.com>
Date:   Tue, 26 Jul 2022 14:54:59 +0800
From:   Hanjun Guo <guohanjun@...wei.com>
To:     Ren Zhijie <renzhijie2@...wei.com>, <lpieralisi@...nel.org>,
        <sudeep.holla@....com>, <rafael@...nel.org>, <lenb@...nel.org>,
        <shameerali.kolothum.thodi@...wei.com>, <jroedel@...e.de>,
        <robin.murphy@....com>
CC:     <linux-acpi@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 -next] ACPI/IORT: Fix build error
 implicit-function-declaration

On 2022/7/26 11:35, Ren Zhijie wrote:
> If CONFIG_ACPI_IORT=y and CONFIG_IOMMU_API is not set,
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-,
> will be failed, like this:
> 
> drivers/acpi/arm64/iort.c: In function ‘iort_get_rmr_sids’:
> drivers/acpi/arm64/iort.c:1406:2: error: implicit declaration of function ‘iort_iommu_rmr_get_resv_regions’; did you mean ‘iort_iommu_get_resv_regions’? [-Werror=implicit-function-declaration]
>    iort_iommu_rmr_get_resv_regions(iommu_fwnode, NULL, head);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    iort_iommu_get_resv_regions
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/acpi/arm64/iort.o] Error 1
> 
> The function iort_iommu_rmr_get_resv_regions()
> is declared under CONFIG_IOMMU_API,
> and the callers of iort_get_rmr_sids() and iort_put_rmr_sids()
> would select IOMMU_API.
> 
> To fix this error, move the definitions to #ifdef CONFIG_IOMMU_API.
> 
> Fixes: e302eea8f497 ("ACPI/IORT: Add a helper to retrieve RMR info directly")
> Signed-off-by: Ren Zhijie <renzhijie2@...wei.com>
> ---
> Changes in v2:
>   - change commit message to a max of 75 chars per line.
> 

Acked-by: Hanjun Guo <guohanjun@...wei.com>

Lorenzo, will this patch go via ARM64 tree?

Thanks
Hanjun