linux-kernel - Re: [PATCH 1/3] dt-bindings: mediatek: add pinctrl definition for mt8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 26 Jul 2022 11:45:25 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "hui.liu" <hui.liu@...iatek.com>, linus.walleij@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        matthias.bgg@...il.com
Cc:     johnson.wang@...iatek.com, zhiyong.tao@...iatek.com,
        sean.wang@...iatek.com, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mediatek: add pinctrl definition for
 mt8188

On 25/07/2022 12:10, hui.liu wrote:
> On Fri, 2022-07-22 at 20:19 +0200, Krzysztof Kozlowski wrote:
>> On 22/07/2022 03:40, hui.liu wrote:
>>> Hi, Krzysztof
>>>
>>> That's the comment about reg and reg-names description:
>>>>> +  reg:
>>>>> +    description: |
>>>>> +      Physical address base for gpio base registers. There are
>>>>> 8
>>>>> GPIO
>>>>> +      physical address base in mt8188.
>>>>
>>>> Redundant description, skip it. You should list the instead and
>>>> describe
>>>> each of it.
>>>>
>>>>> +    maxItems: 8
>>>>> +
>>>>> +  reg-names:
>>>>> +    description: |
>>>>> +      Gpio base register names.
>>>>
>>>> Redundant description, skip it.
>>>>
>>>>> +    maxItems: 8
>>>>
>>>> You need to list the items instead.
>>>
>>> I plan to update reg and reg-names as the following:
>>>   reg:
>>>     description: |
>>>       Physical address base for gpio base registers. There are 6
>>> different GPIO physical address bases in mt8188.
>>>     minItems: 6
>>>     maxItems: 6
>>
>> You should rather have here items with description:
>> items:
>>  - description: what is it
>>  - description: what is it
>>  ....
>>
> 
> Hi Krzysztof,
> 
> I will list each items with description as follows, is it right?
>   reg:
>     description: |
>       Physical address base for pinctrl base registers. There are 6
> different physical address bases in mt8188.
>       iocfg0 is gpio base address;
>       iocfg_rm is io configuration
> address for rm group;
>       iocfg_lt is io configuration address for lt group;
>       iocfg_lm
> is io configuration address for mm group;
>       iocfg_rt is io
> configuration address for rt group;
>       eint is eint base address.
>     minItems: 6
>     maxItems: 6

No, because it is not schema and you still keep here min/maxItems which
are pointless in that case. Just read example-schema.

https://elixir.bootlin.com/linux/v5.19-rc8/source/Documentation/devicetree/bindings/example-schema.yaml#L63


Best regards,
Krzysztof