linux-kernel - Re: [PATCH v3 2/3] dt-bindings: clock: add SM6375 QCOM global clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b938039-0a73-90e5-47c1-4d976d278273@somainline.org>
Date:   Tue, 26 Jul 2022 11:54:24 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: clock: add SM6375 QCOM global clock
 bindings



On 26.07.2022 11:52, Krzysztof Kozlowski wrote:
> On 23/07/2022 22:56, Konrad Dybcio wrote:
>>
>>
>> On 23.07.2022 19:46, Krzysztof Kozlowski wrote:
>>> On 23/07/2022 12:01, Konrad Dybcio wrote:
>>>> Add device tree bindings for global clock controller for SM6375 SoCs.
>>>>
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
>>>> ---
>>>> Changes since v2:
>>>> - reference qcom,gcc.yaml
>>>>
>>>>  .../bindings/clock/qcom,sm6375-gcc.yaml       |  48 ++++
>>>>  include/dt-bindings/clock/qcom,sm6375-gcc.h   | 234 ++++++++++++++++++
>>>>  2 files changed, 282 insertions(+)
>>>>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>>>>  create mode 100644 include/dt-bindings/clock/qcom,sm6375-gcc.h
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>>>> new file mode 100644
>>>> index 000000000000..fb1c36888d18
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>>>> @@ -0,0 +1,48 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/clock/qcom,sm6375-gcc.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Qualcomm Global Clock & Reset Controller Binding for SM6375
>>>> +
>>>> +maintainers:
>>>> +  - Konrad Dybcio <konrad.dybcio@...ainline.org>
>>>> +
>>>> +description: |
>>>> +  Qualcomm global clock control module which supports the clocks, resets and
>>>> +  power domains on SM6375
>>>> +
>>>> +  See also:
>>>> +  - dt-bindings/clock/qcom,sm6375-gcc.h
>>>> +
>>>> +allOf:
>>>> +  - $ref: qcom,gcc.yaml#
>>>> +
>>>> +properties:
>>>> +  compatible:
>>>> +    const: qcom,sm6375-gcc
>>>> +
>>>> +  clocks:
>>>> +    items:
>>>> +      - description: Board XO source
>>>> +      - description: Board XO Active-Only source
>>>> +      - description: Sleep clock source
>>>
>>> What happened to clock-names?
>>>
>>>> +
>>>
>>> I would assume these are required for the clock controller... and they
>>> were before, so what happened?
>> I dropped them in v2, as with switching the .c driver to use the
>> index matching, they are no longer used.
> 
> OK, but what about clocks as required? Why aren't these now required?
Ohhhh right, I had a false impression that they were set in qcom,gcc.yaml.
Will fix it.

Konrad
> 
> 
> Best regards,
> Krzysztof