linux-kernel - Re: [PATCH 5/7] venus : Addition of support for VIDIOC_TRY_ENCODER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51eb6fd9-928f-bd97-d603-e9096402c799@linaro.org>
Date:   Tue, 26 Jul 2022 13:05:50 +0300
From:   Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:     Viswanath Boma <quic_vboma@...cinc.com>,
        video.upstream.external@....qualcomm.com,
        Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Dikshita Agarwal <dikshita@...eaurora.org>
Subject: Re: [PATCH 5/7] venus : Addition of support for
 VIDIOC_TRY_ENCODER_CMD



On 7/12/22 15:23, Viswanath Boma wrote:
> From: Dikshita Agarwal <dikshita@...eaurora.org>
> 
>   v4l2 compliance expecting support for vidioc_try_encoder_cmd
>   error details : test VIDIOC_(TRY_)ENCODER_CMD: FAIL
> 
> Change-Id: I87a655dc506f3e713e2c86ab5203ca9c45cc5e1b

Drop Change-Id and add Dikshita's Signed-off tag.

> Signed-off-by: Viswanath Boma <quic_vboma@...cinc.com>
> ---
>  drivers/media/platform/qcom/venus/venc.c | 1 +
>  1 file changed, 1 insertion(+)

With above comments fixed you can add my:

Acked-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>

> 
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index 30ddb84c24997..4f10f5de7e3e6 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -589,6 +589,7 @@ static const struct v4l2_ioctl_ops venc_ioctl_ops = {
>  	.vidioc_subscribe_event = venc_subscribe_event,
>  	.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
>  	.vidioc_encoder_cmd = venc_encoder_cmd,
> +	.vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd,
>  };
>  
>  static int venc_pm_get(struct venus_inst *inst)

-- 
regards,
Stan