[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <57f8d9c4-6f49-ad3d-fc82-7a0f66d1775a@linaro.org>
Date: Tue, 26 Jul 2022 12:27:12 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Anjelique Melendez <quic_amelende@...cinc.com>, corbet@....net,
sre@...nel.org, robh+dt@...nel.org, agross@...nel.org,
bjorn.andersson@...aro.org
Cc: krzysztof.kozlowski+dt@...aro.org, vkoul@...nel.org,
linux-doc@...r.kernel.org, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] power: reset: qcom-pon: add support for
qcom,pmk8350-pon compatible string
On 25/07/2022 21:13, Anjelique Melendez wrote:
> Add support for the new "qcom,pmk8350-pon" comptaible string.
>
> Signed-off-by: Anjelique Melendez <quic_amelende@...cinc.com>
> ---
> drivers/power/reset/qcom-pon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 4a688741a88a..16bc01738be9 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -82,6 +82,7 @@ static const struct of_device_id pm8916_pon_id_table[] = {
> { .compatible = "qcom,pm8916-pon", .data = (void *)GEN1_REASON_SHIFT },
> { .compatible = "qcom,pms405-pon", .data = (void *)GEN1_REASON_SHIFT },
> { .compatible = "qcom,pm8998-pon", .data = (void *)GEN2_REASON_SHIFT },
> + { .compatible = "qcom,pmk8350-pon", .data = (void *)GEN2_REASON_SHIFT },
> { }
> };
> MODULE_DEVICE_TABLE(of, pm8916_pon_id_table);
This is now confusing. The new device has entirely different first and
second IO address spaces, but you do not code here any differences.
Best regards,
Krzysztof
Powered by blists - more mailing lists