linux-kernel - Re: [PATCH v2 3/5] ASoC: mchp-spdiftx: remove references to mchp_i2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yt/GQ80pj2JiRA0a@sirena.org.uk>
Date:   Tue, 26 Jul 2022 11:47:31 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        alsa-devel@...a-project.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] ASoC: mchp-spdiftx: remove references to
 mchp_i2s_caps

On Mon, Jul 25, 2022 at 04:09:23PM +0300, Claudiu Beznea wrote:

> @@ -782,11 +780,6 @@ static int mchp_spdiftx_probe(struct platform_device *pdev)
>  	if (!dev)
>  		return -ENOMEM;
>  
> -	/* Get hardware capabilities. */
> -	match = of_match_node(mchp_spdiftx_dt_ids, np);
> -	if (match)
> -		dev->caps = match->data;
> -

This breaks an x86_64 allmodconfig build:

/build/stage/linux/sound/soc/atmel/mchp-spdiftx.c: In function ‘mchp_spdiftx_pro
be’:
/build/stage/linux/sound/soc/atmel/mchp-spdiftx.c:766:29: error: unused variable
 ‘np’ [-Werror=unused-variable]
  766 |         struct device_node *np = pdev->dev.of_node;
      |                             ^~
cc1: all warnings being treated as errors

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)