linux-kernel - Re: [PATCH 03/10] soc: qcom: icc-bwmon: drop unused BWMON_ZONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <689ae7a0-bb23-8264-a2ff-40b1b5bbf0af@quicinc.com>
Date:   Tue, 26 Jul 2022 16:55:14 +0530
From:   Sibi Sankar <quic_sibis@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "Konrad Dybcio" <konrad.dybcio@...ainline.org>,
        Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     Rajendra Nayak <quic_rjendra@...cinc.com>
Subject: Re: [PATCH 03/10] soc: qcom: icc-bwmon: drop unused BWMON_ZONE_COUNT

Hey Krzysztof,

Thanks for working on the llcc bwmon patch series!


On 7/21/22 12:58 AM, Krzysztof Kozlowski wrote:
> BWMON_ZONE_COUNT define is not used.
> 
> Cc: Rajendra Nayak <quic_rjendra@...cinc.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   drivers/soc/qcom/icc-bwmon.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
> index 3415f42523cd..b76a59d9002c 100644
> --- a/drivers/soc/qcom/icc-bwmon.c
> +++ b/drivers/soc/qcom/icc-bwmon.c
> @@ -105,7 +105,6 @@
>   
>   /* BWMONv4 count registers use count unit of 64 kB */
>   #define BWMON_COUNT_UNIT_KB			64
> -#define BWMON_ZONE_COUNT			0x2d8

Apart from ^^ a few more defines like BWMON_GLOBAL_IRQ_STATUS,
THRESHOLD_COUNT_ZONE2_SHIFT were unused as well.

Reviewed-by: Sibi Sankar <quic_sibis@...cinc.com>

>   #define BWMON_ZONE_MAX(zone)			(0x2e0 + 4 * (zone))
>   
>   struct icc_bwmon_data {
>