linux-kernel - Re: [PATCH v2 3/5] thermal: qcom: tsens: Add driver support for re-initialization quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1e7ac3b-e3e3-4843-2a07-f9f05b49c2b9@linaro.org>
Date:   Tue, 26 Jul 2022 17:08:13 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     kernel test robot <lkp@...el.com>, linux-pm@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, bhupesh.linux@...il.com,
        linux-kernel@...r.kernel.org, bjorn.andersson@...aro.org,
        konrad.dybcio@...ainline.org, linux-arm-msm@...r.kernel.org,
        daniel.lezcano@...aro.org, robh+dt@...nel.org, rafael@...nel.org,
        Amit Kucheria <amitk@...nel.org>,
        Thara Gopinath <thara.gopinath@...il.com>
Subject: Re: [PATCH v2 3/5] thermal: qcom: tsens: Add driver support for
 re-initialization quirk

Hi,

On 7/26/22 4:40 AM, kernel test robot wrote:
> Hi Bhupesh,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on rafael-pm/thermal]
> [also build test ERROR on linus/master v5.19-rc8 next-20220725]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Bhupesh-Sharma/Add-support-for-tsens-controller-reinit-via-trustzone/20220724-202546
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
> config: ia64-randconfig-r005-20220724 (https://download.01.org/0day-ci/archive/20220726/202207260755.tUajnfB4-lkp@intel.com/config)
> compiler: ia64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/intel-lab-lkp/linux/commit/2356630fadc0a622264bf292b6930f8c728b0709
>          git remote add linux-review https://github.com/intel-lab-lkp/linux
>          git fetch --no-tags linux-review Bhupesh-Sharma/Add-support-for-tsens-controller-reinit-via-trustzone/20220724-202546
>          git checkout 2356630fadc0a622264bf292b6930f8c728b0709
>          # save the config file
>          mkdir build_dir && cp config build_dir/.config
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>     ia64-linux-ld: drivers/thermal/qcom/tsens.o: in function `tsens_probe':
>>> tsens.c:(.text+0x6d2): undefined reference to `qcom_scm_is_available'
>     ia64-linux-ld: drivers/thermal/qcom/tsens.o: in function `tsens_health_check_and_reinit.constprop.0':
>>> tsens.c:(.text+0x10c2): undefined reference to `qcom_scm_tsens_reinit'

It seems you have missed picking up [PATCH 1/5] firmware: qcom: scm: Add 
support for tsens reinit workaround before running the checks on this 
patch which is a part of this series itself (see [1]).

If I pick the PATCHes in the right order [PATCH 1/5], [PATCH 2/5] 
followed by [PATCH 3/5], I don't see the compilation error being 
reported (even with W=1 build options).

[1]. 
https://lore.kernel.org/linux-arm-msm/20220724122424.2509021-2-bhupesh.sharma@linaro.org/

Thanks,
Bhupesh