linux-kernel - Re: [PATCH 1/1] iommu/hyper-v: Use helper instead of directly accessing affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220726130909.jnj5etogffm4b2c5@liuwe-devbox-debian-v2>
Date:   Tue, 26 Jul 2022 13:09:09 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Joerg Roedel <joro@...tes.org>
Cc:     Michael Kelley <mikelley@...rosoft.com>, sthemmin@...rosoft.com,
        kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
        decui@...rosoft.com, will@...nel.org, robin.murphy@....com,
        samuel@...lland.org, linux-kernel@...r.kernel.org,
        linux-hyperv@...r.kernel.org, iommu@...ts.linux.dev
Subject: Re: [PATCH 1/1] iommu/hyper-v: Use helper instead of directly
 accessing affinity

On Tue, Jul 26, 2022 at 09:15:58AM +0200, Joerg Roedel wrote:
> Hi Michael,
> 
> On Mon, Jul 25, 2022 at 05:53:40PM -0700, Michael Kelley wrote:
> > Recent changes to solve inconsistencies in handling IRQ masks #ifdef
> > out the affinity field in irq_common_data for non-SMP configurations.
> > The current code in hyperv_irq_remapping_alloc() gets a compiler error
> > in that case.
> > 
> > Fix this by using the new irq_data_update_affinity() helper, which
> > handles the non-SMP case correctly.
> > 
> > Signed-off-by: Michael Kelley <mikelley@...rosoft.com>
> 
> Please add a fixes tag.
> 
> Where is the change which breaks this currently, in some subsystem tree
> or already upstream?
> 

The offending patch aa081358 is in linux-next.

> In case it is still in a maintainers tree, this patch should be applied
> there. Here is my
> 
> Acked-by: Joerg Roedel <jroedel@...e.de>

I can take this patch via hyperv-next. This is a good improvement
anyway.

Thanks,
Wei.

> 
> for that.
>