lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Jul 2022 08:51:39 -0700 From: Yury Norov <yury.norov@...il.com> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Guenter Roeck <linux@...ck-us.net>, Dennis Zhou <dennis@...nel.org>, Russell King - ARM Linux <linux@...linux.org.uk>, Catalin Marinas <catalin.marinas@....com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: Linux 5.19-rc8 On Mon, Jul 25, 2022 at 01:40:58PM -0700, Linus Torvalds wrote: > On Mon, Jul 25, 2022 at 1:35 PM Yury Norov <yury.norov@...il.com> wrote: > > > > Here we have 2 ugly options - having pairs of almost identical > > functions, or passing dummy variables. I decided that copy-pasting is > > worse than abusing branch predictor. > > The thing is, we have solutions for this - just use a single inline > function, and make it *see* the constant. > > That way the compiler can DTRT, either generating two copies (with the > constant elided) or depending on the branch predictor. > > That's particularly true in a case like this, when there is only *one* > case for the normal situation (ie little-endian). Because let's face > it, big-endian is completely dead and legacy model. OK, I'll do it for 5.20. Thanks for the hint.
Powered by blists - more mailing lists