linux-kernel - Re: [PATCH] mm: fix NULL pointer dereference in wp_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wh_TrgNm6vz7=7CgZppr0UrZ9TwLyb3dgPXyG-w=a8kJQ@mail.gmail.com>
Date:   Tue, 26 Jul 2022 09:26:38 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     David Hildenbrand <david@...hat.com>
Cc:     Qi Zheng <zhengqi.arch@...edance.com>, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: fix NULL pointer dereference in wp_page_reuse()

On Tue, Jul 26, 2022 at 12:45 AM David Hildenbrand <david@...hat.com> wrote:
>
> >       VM_BUG_ON(!(vmf->flags & FAULT_FLAG_WRITE));
> > -     VM_BUG_ON(PageAnon(page) && !PageAnonExclusive(page));
> > +     VM_BUG_ON(page && PageAnon(page) && !PageAnonExclusive(page));
>
> Indeed, fortunately, only an issue in the VM_BUG_ON statement

Well, at least Fedora ends up enabling CONFIG_DEBUG_VM by default, so
normal people - not just VM people - can definitely see this.

> Reviewed-by: David Hildenbrand <david@...hat.com>

Applied.

                    Linus