linux-kernel - Re: [PATCH net] netrom: fix sleep in atomic context bugs in timer handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14bac17c.5d665.182388522da.Coremail.duoming@zju.edu.cn>
Date:   Tue, 26 Jul 2022 11:20:25 +0800 (GMT+08:00)
From:   duoming@....edu.cn
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     linux-hams@...r.kernel.org, ralf@...ux-mips.org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] netrom: fix sleep in atomic context bugs in timer
 handlers

Hello,

On Mon, 25 Jul 2022 19:49:30 -0700 Jakub Kicinski wrote:

> On Sat, 23 Jul 2022 11:56:46 +0800 Duoming Zhou wrote:
> > Fixes: eafff86d3bd8 ("[NETROM]: Use kmemdup")
> 
> That's not a correct Fixes tag, acme just swapped kmalloc for kmemdup().
> The allocate flags did not change.

Thanks for your time and reply!

The correct Fixes tag is "Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")".
The following is the code:

https://elixir.bootlin.com/linux/v2.6.12-rc2/source/net/netrom/nr_route.c#L158

...
if ((nr_neigh->digipeat = kmalloc(sizeof(*ax25_digi), GFP_KERNEL)) == NULL) {
...

Best regards,
Duoming Zhou