linux-kernel - Re: [PATCH] usb: typec: retimer: Add missing id check in match callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACeCKaeN12pikzZOVHSv-JQJn4z7Cn61wTqoiAce58-QRSqk_g@mail.gmail.com>
Date:   Tue, 26 Jul 2022 09:50:24 -0700
From:   Prashant Malani <pmalani@...omium.org>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        kernel@...labora.com,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: typec: retimer: Add missing id check in match callback

HI Nícolas,

On Mon, Jul 25, 2022 at 1:31 PM Nícolas F. R. A. Prado
<nfraprado@...labora.com> wrote:
>
> The fwnode_connection_find_match() function handles two cases: named
> references and graph endpoints. In the second case, the match function
> passed in is called with the id to check for the match. However, the
> match function for the recently added type-c retimer class assumes the
> connection has already been matched (which is only true for the first
> case).
>
> The result is that with that change, all type-c nodes with graph
> endpoints defer probe indefinitely, independently of having a retimer
> connection or not.
>
> Add the missing check, like is done by the type-c mux and usb role
> switch code, to fix the issue.
>
> Fixes: ddaf8d96f93b ("usb: typec: Add support for retimers")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
FWIW,
Reviewed-by: Prashant Malani <pmalani@...omium.org>