linux-kernel - Re: [PATCH -next] usb: renesas-xhci: Use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Jul 2022 18:51:39 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chen Xingdi <chenxingdi@...wei.com>
Cc:     mathias.nyman@...el.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, chunkeey@...glemail.com
Subject: Re: [PATCH -next] usb: renesas-xhci: Use pr_info while fw verify
 success

On Tue, Jul 26, 2022 at 02:05:09PM +0800, Chen Xingdi wrote:
> While fw verify success, it is confused to print an error
> log which is actually not an error, so use pr_info to print
> firmware version instead of pr_err.
> 
> Signed-off-by: Chen Xingdi <chenxingdi@...wei.com>
> ---
>  drivers/usb/host/xhci-pci-renesas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c
> index 52599d96634f..1eb1d863d545 100644
> --- a/drivers/usb/host/xhci-pci-renesas.c
> +++ b/drivers/usb/host/xhci-pci-renesas.c
> @@ -151,7 +151,7 @@ static int renesas_fw_verify(const void *fw_data,
>  	}
>  
>  	fw_version = get_unaligned_le16(fw_data + fw_version_pointer);
> -	pr_err("got firmware version: %02x.", fw_version);
> +	pr_info("got firmware version: %02x.", fw_version);

Why print anything at all?  When drivers are working properly, they
should be quiet.  Who relies on this message being sent to the kernel
log?

thanks,

greg k-h