linux-kernel - Re: [PATCH v3 1/5] ARM: qcom_defconfig: enable more Qualcomm drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76bf4b19-54e8-c8cc-be71-356233b1cd57@linaro.org>
Date:   Tue, 26 Jul 2022 20:43:29 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Russell King <linux@...linux.org.uk>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 1/5] ARM: qcom_defconfig: enable more Qualcomm drivers

On 26/07/2022 20:30, Krzysztof Kozlowski wrote:
> On 26/07/2022 18:49, Dmitry Baryshkov wrote:
>> On Tue, 26 Jul 2022 at 18:06, Krzysztof Kozlowski
>> <krzysztof.kozlowski@...aro.org> wrote:
>>>
>>> Enable Qualcomm drivers:
>>> 1. socinfo driver to provide some basic information about the
>>>     SoC being used.
>>> 2. Remote filesystem memory driver (used in MSM8974).
>>> 3. RPM Power domain (used in MSM8226).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>   arch/arm/configs/qcom_defconfig | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
>>> index 5cd935ee148a..f02448187eac 100644
>>> --- a/arch/arm/configs/qcom_defconfig
>>> +++ b/arch/arm/configs/qcom_defconfig
>>> @@ -247,12 +247,15 @@ CONFIG_QCOM_COMMAND_DB=y
>>>   CONFIG_QCOM_GSBI=y
>>>   CONFIG_QCOM_OCMEM=y
>>>   CONFIG_QCOM_PM=y
>>> +CONFIG_QCOM_RMTFS_MEM=y
>>> +CONFIG_QCOM_RPMPD=y
>>>   CONFIG_QCOM_SMEM=y
>>>   CONFIG_QCOM_SMD_RPM=y
>>>   CONFIG_QCOM_SMP2P=y
>>>   CONFIG_QCOM_SMSM=y
>>>   CONFIG_QCOM_RPMH=y
>>>   CONFIG_QCOM_RPMHPD=y
>>> +CONFIG_QCOM_SOCINFO=y
>>
>> please add:
>> CONFIG_QCOM_STATS=y
> 
> I was considering it, but it seems none of ARMv7 DTS use it.

Argh. The driver has support for 8974 and 8084, but nobody has wired 
that up. I'd still suggest marking it as =y/=m. I'll send dtsi patches 
in parallel.

-- 
With best wishes
Dmitry