linux-kernel - Re: [PATCH RFC 4/4] fscrypt: Add new encryption policy for btrfs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220726174538.GG13489@twin.jikos.cz>
Date:   Tue, 26 Jul 2022 19:45:38 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Sweet Tea Dorminy <sweettea-kernel@...miny.me>
Cc:     Eric Biggers <ebiggers@...nel.org>,
        "Theodore Y . Ts'o" <tytso@....edu>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        linux-fscrypt@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-btrfs@...r.kernel.org, osandov@...ndov.com,
        kernel-team@...com
Subject: Re: [PATCH RFC 4/4] fscrypt: Add new encryption policy for btrfs.

On Mon, Jul 25, 2022 at 10:16:07PM -0400, Sweet Tea Dorminy wrote:
> On 7/25/22 19:32, Eric Biggers wrote:
> > On Sat, Jul 23, 2022 at 08:52:28PM -0400, Sweet Tea Dorminy wrote:

> > Given that this new proposal uses per-block metadata, has
> > support for authenticated encryption been considered? Has space been reserved
> > in the per-block metadata for authentication tags so that authenticated
> > encryption support could be added later even if it's not in the initial version?
> 
> I don't know sufficiently much about authenticated encryption to have 
> considered it. As currently drafted, btrfs encrypts before checksumming 
> if checksums are enabled, and checks against checksums before 
> decrypting. Although at present we haven't discussed authentication 
> tags, btrfs could store them in a separate itemtype which could be added 
> at any time, much as we currently store fsverity data. We do have 
> sufficient room saved for adding other encryption types, if necessary; 
> we could use some of that to indicate the existence of authentication 
> tags for the extents' data.

The AEAD tag can be used in place of checksum (also stored in the
checksum item).