linux-kernel - Re: [PATCH 1/2] PCI: qcom: Drop unnecessary <linux/interrupt.h> include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220727192811.GA218230@bhelgaas>
Date:   Wed, 27 Jul 2022 14:28:11 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Stanimir Varbanov <svarbanov@...sol.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Johan Hovold <johan+linaro@...nel.org>,
        Selvam Sathappan Periakaruppan <quic_speriaka@...cinc.com>,
        Baruch Siach <baruch.siach@...lu.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Robert Marko <robimarko@...il.com>,
        Christian Marangi <ansuelsmth@...il.com>,
        linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 1/2] PCI: qcom: Drop unnecessary <linux/interrupt.h>
 include

On Tue, Jul 26, 2022 at 02:21:14PM +0200, Johan Hovold wrote:
> On Fri, Jul 22, 2022 at 10:49:18AM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > pcie-qcom.c uses nothing from <linux/interrupt.h>, so remove the
> > unnecessary include of it.
> 
> Appears to be unused since commit 7c5925afbc58 ("PCI: dwc: Move MSI IRQs
> allocation to IRQ domains hierarchical API") so there may be other
> driver that also no longer need it.

Thanks for digging that out!  You're right, there's a long list of
drivers that include <linux/interrupt.h> but don't appear to need it.
I'm going to drop this patch and try to do them all at once.

> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Reviewed-by: Johan Hovold <johan+linaro@...nel.org>