linux-kernel - Re: [PATCH 5.15 040/201] sysctl: move some boundary constants from sysctl.c to sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Jul 2022 16:44:14 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Luis Chamberlain <mcgrof@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Xiaoming Ni <nixiaoming@...wei.com>,
        Kees Cook <keescook@...omium.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Amir Goldstein <amir73il@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Benjamin LaHaise <bcrl@...ck.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Iurii Zaikin <yzaikin@...gle.com>, Jan Kara <jack@...e.cz>,
        Paul Turner <pjt@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Petr Mladek <pmladek@...e.com>, Qing Wang <wangqing@...o.com>,
        Sebastian Reichel <sre@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Stephen Kitt <steve@....org>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Antti Palosaari <crope@....fi>, Arnd Bergmann <arnd@...db.de>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Clemens Ladisch <clemens@...isch.de>,
        David Airlie <airlied@...ux.ie>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joel Becker <jlbec@...lplan.org>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Julia Lawall <julia.lawall@...ia.fr>,
        Lukas Middendorf <kernel@...force.de>,
        Mark Fasheh <mark@...heh.com>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Douglas Gilbert <dgilbert@...erlog.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Jani Nikula <jani.nikula@...el.com>,
        John Ogness <john.ogness@...utronix.de>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Theodore Tso <tytso@....edu>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 5.15 040/201] sysctl: move some boundary constants from
 sysctl.c to sysctl_vals

On Wed, Jul 27, 2022 at 08:11:03PM +0200, Greg Kroah-Hartman wrote:
>On Wed, Jul 27, 2022 at 10:31:37AM -0700, Luis Chamberlain wrote:
>> On Wed, Jul 27, 2022 at 06:09:04PM +0200, Greg Kroah-Hartman wrote:
>> > From: Xiaoming Ni <nixiaoming@...wei.com>
>> >
>> > [ Upstream commit 78e36f3b0dae586f623c4a37ec5eb5496f5abbe1 ]
>> >
>> > sysctl has helpers which let us specify boundary values for a min or max
>> > int value.  Since these are used for a boundary check only they don't
>> > change, so move these variables to sysctl_vals to avoid adding duplicate
>> > variables.  This will help with our cleanup of kernel/sysctl.c.
>> >
>> > [akpm@...ux-foundation.org: update it for "mm/pagealloc: sysctl: change watermark_scale_factor max limit to 30%"]
>> > [mcgrof@...nel.org: major rebase]
>> >
>> > Link: https://lkml.kernel.org/r/20211123202347.818157-3-mcgrof@kernel.org
>> > Signed-off-by: Xiaoming Ni <nixiaoming@...wei.com>
>> > Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
>> > Reviewed-by: Kees Cook <keescook@...omium.org>
>> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>> > Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
>> > Signed-off-by: Sasha Levin <sashal@...nel.org>
>>
>> I'm a bit puzzled. How / why is this a stable fix?
>
>I think it's needed by a patch later in the series.  Sasha, can you
>verify?

Yes, about 30 patches in this series need this patch.

-- 
Thanks,
Sasha