linux-kernel - Re: [net-next PATCH] octeontx2-pf: Use only non-isolated cpus in irq affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23d40f8c-ad5b-c908-4081-24f882514ad7@gmail.com>
Date:   Wed, 27 Jul 2022 08:28:13 +0300
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Geetha sowjanya <gakula@...vell.com>,
        Tariq Toukan <tariqt@...dia.com>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>
Subject: Re: [net-next PATCH] octeontx2-pf: Use only non-isolated cpus in irq
 affinity



On 7/27/2022 6:08 AM, Jakub Kicinski wrote:
> On Mon, 25 Jul 2022 15:14:02 +0530 Geetha sowjanya wrote:
>> This patch excludes the isolates cpus from the cpus list
>> while setting up TX/RX queue interrupts affinity
>>
>> Signed-off-by: Geetha sowjanya <gakula@...vell.com>
>> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@...vell.com>
> 
> Hm, housekeeping_cpumask() looks barely used by drivers,
> do you have any references to discussions indicated drivers
> are expected to pay attention to it? Really seems like something
> that the core should take care of.
> 
> Tariq, thoughts?

I agree.
IMO this logic best fits inside the new sched API I proposed last week 
(pending Ack...), transparent to driver.

Find here:
https://lore.kernel.org/all/20220719162339.23865-2-tariqt@nvidia.com/