linux-kernel - RE: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR11MB56539D93300DE7709DB0F0DF99979@DM8PR11MB5653.namprd11.prod.outlook.com>
Date:   Wed, 27 Jul 2022 09:41:05 +0000
From:   "Cao, Bingbu" <bingbu.cao@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Qiu, Tian Shu" <tian.shu.qiu@...el.com>,
        "Tu, ShawnX" <shawnx.tu@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: RE: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
 fwnode

Hi, Andy

Thanks for your patch.

Reviewed-by: Bingbu Cao <bingbu.cao@...el.com>

________________________
BRs,  
Bingbu Cao 

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Tuesday, July 26, 2022 8:06 PM
> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; linux-
> media@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Qiu, Tian Shu <tian.shu.qiu@...el.com>; Tu, ShawnX
> <shawnx.tu@...el.com>; Cao, Bingbu <bingbu.cao@...el.com>; Mauro Carvalho
> Chehab <mchehab@...nel.org>
> Subject: [PATCH v1 4/8] media: ov2740: Remove duplicate check for NULL
> fwnode
> 
> fwnode API does proper checks and returns correct codes, no need to repeat
> it in the caller.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/media/i2c/ov2740.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c index
> 9420258c6073..07fe8fda274e 100644
> --- a/drivers/media/i2c/ov2740.c
> +++ b/drivers/media/i2c/ov2740.c
> @@ -1009,9 +1009,6 @@ static int ov2740_check_hwcfg(struct device *dev)
>  	int ret;
>  	unsigned int i, j;
> 
> -	if (!fwnode)
> -		return -ENXIO;
> -
>  	ret = fwnode_property_read_u32(fwnode, "clock-frequency", &mclk);
>  	if (ret)
>  		return ret;
> --
> 2.35.1