lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Jul 2022 10:01:19 +0000 From: "Cao, Bingbu" <bingbu.cao@...el.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: "Qiu, Tian Shu" <tian.shu.qiu@...el.com>, "Tu, ShawnX" <shawnx.tu@...el.com>, Mauro Carvalho Chehab <mchehab@...nel.org> Subject: RE: [PATCH v1 7/8] media: ov2740: Add missed \n to the end of the messages Reviewed-by: Bingbu Cao <bingbu.cao@...el.com> ________________________ BRs, Bingbu Cao > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > Sent: Tuesday, July 26, 2022 8:06 PM > To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; linux- > media@...r.kernel.org; linux-kernel@...r.kernel.org > Cc: Qiu, Tian Shu <tian.shu.qiu@...el.com>; Tu, ShawnX > <shawnx.tu@...el.com>; Cao, Bingbu <bingbu.cao@...el.com>; Mauro Carvalho > Chehab <mchehab@...nel.org> > Subject: [PATCH v1 7/8] media: ov2740: Add missed \n to the end of the > messages > > Add missed \n to the end of the messages. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > --- > drivers/media/i2c/ov2740.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c index > 7271e3d011c9..c4c511f90257 100644 > --- a/drivers/media/i2c/ov2740.c > +++ b/drivers/media/i2c/ov2740.c > @@ -451,7 +451,7 @@ static int ov2740_write_reg_list(struct ov2740 *ov2740, > r_list->regs[i].val); > if (ret) { > dev_err_ratelimited(&client->dev, > - "write reg 0x%4.4x return err = %d", > + "write reg 0x%4.4x return err = %d\n", > r_list->regs[i].address, ret); > return ret; > } > @@ -474,7 +474,7 @@ static int ov2740_identify_module(struct ov2740 > *ov2740) > return ret; > > if (val != OV2740_CHIP_ID) { > - dev_err(&client->dev, "chip id mismatch: %x!=%x", > + dev_err(&client->dev, "chip id mismatch: %x != %x\n", > OV2740_CHIP_ID, val); > return -ENXIO; > } > @@ -772,14 +772,14 @@ static int ov2740_start_streaming(struct ov2740 > *ov2740) > reg_list = &link_freq_configs[link_freq_index].reg_list; > ret = ov2740_write_reg_list(ov2740, reg_list); > if (ret) { > - dev_err(&client->dev, "failed to set plls"); > + dev_err(&client->dev, "failed to set plls\n"); > return ret; > } > > reg_list = &ov2740->cur_mode->reg_list; > ret = ov2740_write_reg_list(ov2740, reg_list); > if (ret) { > - dev_err(&client->dev, "failed to set mode"); > + dev_err(&client->dev, "failed to set mode\n"); > return ret; > } > > @@ -790,7 +790,7 @@ static int ov2740_start_streaming(struct ov2740 > *ov2740) > ret = ov2740_write_reg(ov2740, OV2740_REG_MODE_SELECT, 1, > OV2740_MODE_STREAMING); > if (ret) > - dev_err(&client->dev, "failed to start streaming"); > + dev_err(&client->dev, "failed to start streaming\n"); > > return ret; > } > @@ -801,7 +801,7 @@ static void ov2740_stop_streaming(struct ov2740 > *ov2740) > > if (ov2740_write_reg(ov2740, OV2740_REG_MODE_SELECT, 1, > OV2740_MODE_STANDBY)) > - dev_err(&client->dev, "failed to stop streaming"); > + dev_err(&client->dev, "failed to stop streaming\n"); > } > > static int ov2740_set_stream(struct v4l2_subdev *sd, int enable) > -- > 2.35.1
Powered by blists - more mailing lists