linux-kernel - Re: [PATCH V1] scsi: ufs: Get boot device storage type from command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Jul 2022 21:04:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chetan C R <quic_cchinnad@...cinc.com>, jejb@...ux.ibm.com
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, Chetan C R <quic_cchinnad@...cinc.com>
Subject: Re: [PATCH V1] scsi: ufs: Get boot device storage type from command
 line

Hi Chetan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v5.19-rc8 next-20220726]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chetan-C-R/scsi-ufs-Get-boot-device-storage-type-from-command-line/20220727-163016
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220727/202207272021.6YK4F8UV-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/42a08523b91855ba31b0974a32f02c43b163c571
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Chetan-C-R/scsi-ufs-Get-boot-device-storage-type-from-command-line/20220727-163016
        git checkout 42a08523b91855ba31b0974a32f02c43b163c571
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ufs/host/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/ufs/host/ufs-cmdline.c:19:13: warning: no previous prototype for 'get_storage_boot_device' [-Wmissing-prototypes]
      19 | const char *get_storage_boot_device(void)
         |             ^~~~~~~~~~~~~~~~~~~~~~~


vim +/get_storage_boot_device +19 drivers/ufs/host/ufs-cmdline.c

    18	
  > 19	const char *get_storage_boot_device(void)
    20	{
    21		if (android_boot_dev_v4 && strlen(android_boot_dev_v4))
    22			return android_boot_dev_v4;
    23	
    24		else if (strlen(android_boot_dev_v3))
    25			return android_boot_dev_v3;
    26	
    27		pr_err("Not able to get Bootconfig or Kernel command line param\n");
    28		return NULL;
    29	};
    30	EXPORT_SYMBOL_GPL(get_storage_boot_device);
    31	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp