lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Jul 2022 15:16:18 +0200 From: Bean Huo <huobean@...il.com> To: j-young.choi@...sung.com, ALIM AKHTAR <alim.akhtar@...sung.com>, "avri.altman@....com" <avri.altman@....com>, "bvanassche@....org" <bvanassche@....org>, "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>, "adrian.hunter@...el.com" <adrian.hunter@...el.com>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v4 1/7] scsi: ufs: wb: Move ufshcd_is_wb_allowed() to callee On Wed, 2022-07-27 at 16:04 +0900, Jinyoung CHOI wrote: > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index 8f11f118c30e..a3bdf9986511 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -5722,6 +5722,9 @@ static int __ufshcd_wb_toggle(struct ufs_hba > *hba, bool set, enum flag_idn idn) > enum query_opcode opcode = set ? UPIU_QUERY_OPCODE_SET_FLAG : > UPIU_QUERY_OPCODE_CLEAR_FLAG; > > + if (!ufshcd_is_wb_allowed(hba)) > + return -EPERM; > + Hi J-young, here you should change its return, Otherwise, there will be an fake error printing: dev_err(hba->dev, "%s Write Booster %s failed %d\n", __func__, enable ? "enable" : "disable", ret); Kind regards, Bean
Powered by blists - more mailing lists