linux-kernel - Re: [PATCH] objtool: Fix memory leak in create_static_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YuFf5LiWGLH6ul5E@worktop.programming.kicks-ass.net>
Date:   Wed, 27 Jul 2022 17:55:16 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Stanislav Goriainov <goriainov@...ras.ru>
Cc:     Josh Poimboeuf <jpoimboe@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] objtool: Fix memory leak in create_static_call_section()

On Wed, Jul 27, 2022 at 06:48:25PM +0300, Stanislav Goriainov wrote:
> On some paths of function create_static_call_section() the memory,
> allocated for key_name via strdup(), is not freed. Even though this
> is a utility function, and all memory will be freed automatically
> after the process is finished, there is free(key_sym) in some cases,
> so it would be sensible to always deallocate the memory.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 

This is a run-once die on error program. This is pointless and most
certainly doesn't 'fix' anything.