linux-kernel - [PATCH v2 -next] usb: renesas-xhci: Do not print any log while fw verif success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220727031146.19345-1-chenxingdi@huawei.com>
Date:   Wed, 27 Jul 2022 11:11:46 +0800
From:   Chen Xingdi <chenxingdi@...wei.com>
To:     <mathias.nyman@...el.com>
CC:     <gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <chunkeey@...glemail.com>,
        <chenxingdi@...wei.com>
Subject: [PATCH v2 -next] usb: renesas-xhci: Do not print any log while fw verif success

When drivers are working properly, they should be quiet.

Signed-off-by: Chen Xingdi <chenxingdi@...wei.com>
---
v2:
- delete the log instead of change the log level to info.
 drivers/usb/host/xhci-pci-renesas.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c
index 52599d96634f..93f8b355bc70 100644
--- a/drivers/usb/host/xhci-pci-renesas.c
+++ b/drivers/usb/host/xhci-pci-renesas.c
@@ -120,7 +120,6 @@ static int renesas_fw_verify(const void *fw_data,
 			     size_t length)
 {
 	u16 fw_version_pointer;
-	u16 fw_version;
 
 	/*
 	 * The Firmware's Data Format is describe in
@@ -150,9 +149,6 @@ static int renesas_fw_verify(const void *fw_data,
 		return -EINVAL;
 	}
 
-	fw_version = get_unaligned_le16(fw_data + fw_version_pointer);
-	pr_err("got firmware version: %02x.", fw_version);
-
 	return 0;
 }
 
-- 
2.17.1