linux-kernel - Re: [PATCH] platform/x86: remove useless comparisons in sony_pic_read_possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <846d5138-f846-1f5b-39bd-2bd20595a9a2@redhat.com>
Date:   Thu, 28 Jul 2022 19:41:59 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andrey Strachuk <strochuk@...ras.ru>,
        Mattia Dongili <malattia@...ux.it>
Cc:     Mark Gross <markgross@...nel.org>, Len Brown <len.brown@...el.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] platform/x86: remove useless comparisons in
 sony_pic_read_possible_resource()

Hi,

On 7/19/22 13:03, Andrey Strachuk wrote:
> Local variable 'p' is initialized by an address
> of field of acpi_resource structure, so it does
> not make sense to compare 'p' with NULL.
> 
> Local variable 'io' is initialized by an address
> of field of acpi_resource structure, so it does
> not make sense to compare 'io' with NULL.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrey Strachuk <strochuk@...ras.ru>
> Fixes: 41b16dce3905 ("create drivers/platform/x86/ from drivers/misc/")

Thank you for your patch, I've applied this patch (minus the
invalid fixes tag) to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/sony-laptop.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index d8d0c0bed5e9..07ef05f727a2 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -4341,7 +4341,7 @@ sony_pic_read_possible_resource(struct acpi_resource *resource, void *context)
>  		{
>  			struct acpi_resource_irq *p = &resource->data.irq;
>  			struct sony_pic_irq *interrupt = NULL;
> -			if (!p || !p->interrupt_count) {
> +			if (!p->interrupt_count) {
>  				/*
>  				 * IRQ descriptors may have no IRQ# bits set,
>  				 * particularly those those w/ _STA disabled
> @@ -4374,11 +4374,6 @@ sony_pic_read_possible_resource(struct acpi_resource *resource, void *context)
>  			struct acpi_resource_io *io = &resource->data.io;
>  			struct sony_pic_ioport *ioport =
>  				list_first_entry(&dev->ioports, struct sony_pic_ioport, list);
> -			if (!io) {
> -				dprintk("Blank IO resource\n");
> -				return AE_OK;
> -			}
> -
>  			if (!ioport->io1.minimum) {
>  				memcpy(&ioport->io1, io, sizeof(*io));
>  				dprintk("IO1 at 0x%.4x (0x%.2x)\n", ioport->io1.minimum,