linux-kernel - Re: [PATCH 1/6] hugetlb_cgroup: remove unneeded nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jul 2022 10:44:20 -0700
From:   Mina Almasry <almasrymina@...gle.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, mike.kravetz@...cle.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] hugetlb_cgroup: remove unneeded nr_pages > 0 check

On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>
> When code reaches here, nr_pages must be > 0. Remove unneeded nr_pages > 0
> check to simplify the code.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Thanks Miaohe,

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

> ---
>  mm/hugetlb_cgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> index c86691c431fd..d16eb00c947d 100644
> --- a/mm/hugetlb_cgroup.c
> +++ b/mm/hugetlb_cgroup.c
> @@ -442,7 +442,7 @@ void hugetlb_cgroup_uncharge_file_region(struct resv_map *resv,
>         if (hugetlb_cgroup_disabled() || !resv || !rg || !nr_pages)
>                 return;
>
> -       if (rg->reservation_counter && resv->pages_per_hpage && nr_pages > 0 &&
> +       if (rg->reservation_counter && resv->pages_per_hpage &&
>             !resv->reservation_counter) {
>                 page_counter_uncharge(rg->reservation_counter,
>                                       nr_pages * resv->pages_per_hpage);
> --
> 2.23.0
>