[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2640c637-68c7-641d-9b15-c57bdd5adca2@linaro.org>
Date: Thu, 28 Jul 2022 19:54:12 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Pin-yen Lin <treapking@...omium.org>,
Matthias Brugger <matthias.bgg@...il.com>,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: Eizan Miyamoto <eizan@...omium.org>,
Evan Benn <evanbenn@...omium.org>,
Hsin-Yi Wang <hsinyi@...omium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3] arm64: dts: mt8173-oak: Switch to SMC watchdog
On 28/07/2022 17:39, Pin-yen Lin wrote:
> Switch to SMC watchdog because we need direct control of HW watchdog
> registers from kernel. The corresponding firmware was uploaded in
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
>
> Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> ---
>
> Changes in v3:
> - Remove /delete-node/ and create a new node for SMC watchdog.
>
> Changes in v2:
> - Move the modifications to mt8173-elm.dtsi and add some comments.
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index e21feb85d822..fc8203297bac 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
> };
> };
> };
> +
> +
Why?
> + smc_watchdog {
No, you need to read the comment you receive one more time. So to be
clear: "watchdog"
Best regards,
Krzysztof
Powered by blists - more mailing lists