linux-kernel - Re: [PATCH 5/6] hugetlb_cgroup: use helper macro NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izOyzU9D8iTzhe-nbtxfFyhwLur5EHv+z0N5NMTLQobY7A@mail.gmail.com>
Date:   Thu, 28 Jul 2022 11:00:24 -0700
From:   Mina Almasry <almasrymina@...gle.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, mike.kravetz@...cle.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] hugetlb_cgroup: use helper macro NUMA_NO_NODE

On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>
> It's better to use NUMA_NO_NODE instead of magic number -1. Minor
> readability improvement.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

> ---
>  mm/hugetlb_cgroup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> index 7e0bca52c40f..13ec091385af 100644
> --- a/mm/hugetlb_cgroup.c
> +++ b/mm/hugetlb_cgroup.c
> @@ -153,9 +153,9 @@ hugetlb_cgroup_css_alloc(struct cgroup_subsys_state *parent_css)
>          * function.
>          */
>         for_each_node(node) {
> -               /* Set node_to_alloc to -1 for offline nodes. */
> +               /* Set node_to_alloc to NUMA_NO_NODE for offline nodes. */
>                 int node_to_alloc =
> -                       node_state(node, N_NORMAL_MEMORY) ? node : -1;
> +                       node_state(node, N_NORMAL_MEMORY) ? node : NUMA_NO_NODE;
>                 h_cgroup->nodeinfo[node] =
>                         kzalloc_node(sizeof(struct hugetlb_cgroup_per_node),
>                                      GFP_KERNEL, node_to_alloc);
> --
> 2.23.0
>