linux-kernel - Re: [PATCH] fpga: microchip-spi: add missing module author entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2ae744c-990f-a432-7cd5-b7e1e440ad4e@microchip.com>
Date:   Thu, 28 Jul 2022 19:18:54 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <i.bornyakov@...rotek.ru>, <Conor.Dooley@...rochip.com>
CC:     <mdf@...nel.org>, <hao.wu@...el.com>, <yilun.xu@...el.com>,
        <trix@...hat.com>, <linux-fpga@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fpga: microchip-spi: add missing module author entry



On 28/07/2022 19:46, Ivan Bornyakov wrote:
> On Thu, Jul 28, 2022 at 08:50:13AM +0100, Conor Dooley wrote:
>> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
>> programming driver.
>>
>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>> ---
>>  drivers/fpga/microchip-spi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
>> index bd284c7b8dc9..7436976ea904 100644
>> --- a/drivers/fpga/microchip-spi.c
>> +++ b/drivers/fpga/microchip-spi.c
>> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
>>  module_spi_driver(mpf_driver);
>>  
>>  MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
>> +MODULE_AUTHOR("Ivan Bornyakov <i.bornyakov@...rotek.ru>");
>>  MODULE_LICENSE("GPL");
>> -- 
>> 2.36.1
>>
> 
> Acked-by: Ivan Bornyakov <i.bornyakov@...rotek.ru>
> 
> Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've
> submitted a couple of other drivers without it, should I fix them?
> 

It'll show up in modinfo. I don't think it's a big deal though.
/shrug
Conor.