linux-kernel - Re: [PATCH] nouveau/svm: Fix to migrate all requested pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84ec4ad5-a580-1a43-27ed-d47dbdf7d1bc@nvidia.com>
Date:   Thu, 28 Jul 2022 12:27:45 -0700
From:   Ralph Campbell <rcampbell@...dia.com>
To:     Alistair Popple <apopple@...dia.com>, bskeggs@...hat.com
Cc:     kherbst@...hat.com, lyude@...hat.com, airlied@...ux.ie,
        daniel@...ll.ch, nouveau@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        jhubbard@...dia.com
Subject: Re: [PATCH] nouveau/svm: Fix to migrate all requested pages

On 7/19/22 23:27, Alistair Popple wrote:

> Users may request that pages from an OpenCL SVM allocation be migrated
> to the GPU with clEnqueueSVMMigrateMem(). In Nouveau this will call into
> nouveau_dmem_migrate_vma() to do the migration. If the total range to be
> migrated exceeds SG_MAX_SINGLE_ALLOC the pages will be migrated in
> chunks of size SG_MAX_SINGLE_ALLOC. However a typo in updating the
> starting address means that only the first chunk will get migrated.
>
> Fix the calculation so that the entire range will get migrated if
> possible.
>
> Signed-off-by: Alistair Popple <apopple@...dia.com>
> Fixes: e3d8b0890469 ("drm/nouveau/svm: map pages after migration")

Thanks for fixing this!
Reviewed-by: Ralph Campbell <rcampbell@...dia.com>