linux-kernel - Re: [PATCH] dt-bindings: mailbox: arm,mhu: Make secure interrupt optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABb+yY2jV7c8oX7=F=nocfvGrOMHJAYov7zS2nT0=qFoNyoxJQ@mail.gmail.com>
Date:   Thu, 28 Jul 2022 15:17:01 -0500
From:   Jassi Brar <jassisinghbrar@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mailbox: arm,mhu: Make secure interrupt optional

On Thu, Jul 28, 2022 at 2:08 PM Rob Herring <robh@...nel.org> wrote:
>
> The secure interrupt is only useful to secure world, therefore for NS
> users it shouldn't be required. Make it optional.
>
> This fixes a warning on Arm Juno board:
>
> mhu@...f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index bd49c201477d..d9a4f4a02d7c 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -57,6 +57,7 @@ properties:
>      maxItems: 1
>
>    interrupts:
> +    minItems: 2
>      items:
>        - description: low-priority non-secure
>        - description: high-priority non-secure
>
Do we also want to specify that only the secure-irq is optional
because irqs are directly mapped onto channels in the driver, and only
omitting the secure (last) irq will work.

thanks



> --
> 2.34.1
>