linux-kernel - Re: [PATCH v3 1/2] dt-bindings: arm: qcom: document zoglin board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jul 2022 14:47:54 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Bob Moragues <moragues@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rob Herring <robh@...nel.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Stephen Boyd <sboyd@...eaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: qcom: document zoglin board

Hi,

On Thu, Jul 28, 2022 at 2:33 PM Bob Moragues <moragues@...omium.org> wrote:
>
> Zoglin is a Hoglin Chromebook with SPI Flash reduced from 64MB to 8MB.
> Zoglin is identical to Hoglin except for the SPI Flash.
> The actual SPI Flash is dynamically probed at and not specified in DTS.
>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Acked-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Bob Moragues <moragues@...omium.org>

A nit from my point of view is that I would have expected your
Signed-off-by to be the first tag. As I understand it the tags are
usually supposed to be a top-to-bottom history of what happened. You
signed off on the patch and then people added reviews / acks. I don't
personally think this is important enough to spin a v4 for, though the
last word would be Bjorn.

> ---
>
> Changes in v3:
> - Fixed Author
> - Fixed duplicate Signed-off-by

Technically this should have been:

Changes in v3:
- Really really fixed Signed-off-by

Changes in v2:
- Fixed Author
- Fixed duplicate Signed-off-by

...but that's also not really worth spinning for.

I think this looks good now. Though unofficial (and not stable git
hashes), I've been trying to keep track of some patches during this
dead time till -rc1. I've put your two patches here:

https://github.com/dianders/kernel-staging/commits/qcom/arm64-staging

-Doug