linux-kernel - Re: [PATCH V1] scsi: ufs: Get boot device storage type from command line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c66ffd91-8649-edb7-86dc-422ae82e1b84@quicinc.com>
Date:   Thu, 28 Jul 2022 14:05:18 +0530
From:   "Chetan Chinnadagudihundi Ravindranath (Consultant) (QUIC)" 
        <quic_cchinnad@...cinc.com>
To:     Bart Van Assche <bvanassche@....org>, <jejb@...ux.ibm.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH V1] scsi: ufs: Get boot device storage type from command
 line

Hi Brat,

Thanks for you response!

Yes, since SCSI_UFSHCD=y am selecting UFS_QCOM_CMDLINE=y so that it gets 
__setup() declarations. I am able to read the command line arguments and 
get this "androidboot.bootdevice=" info. I had cross checked again.

Thanks,
Chetan C R

On 7/27/2022 11:16 PM, Bart Van Assche wrote:
> On 7/27/22 01:28, Chetan C R wrote:
>> diff --git a/drivers/ufs/Kconfig b/drivers/ufs/Kconfig
>> index 90226f7..9d2f84e 100644
>> --- a/drivers/ufs/Kconfig
>> +++ b/drivers/ufs/Kconfig
>> @@ -9,6 +9,7 @@ menuconfig SCSI_UFSHCD
>>       select PM_DEVFREQ
>>       select DEVFREQ_GOV_SIMPLE_ONDEMAND
>>       select NLS
>> +    select UFS_QCOM_CMDLINE if ARCH_QCOM
>>       help
>>         Enables support for UFS (Universal Flash Storage) host 
>> controllers.
>>         A UFS host controller is an electronic component that is able to
>
> [ ... ]
>
>> +__setup("androidboot.bootdevice=", get_android_boot_dev_v3);
>
> How can this work since __setup() declarations should occur in the 
> core kernel and since the ufshcd driver can be built as a kernel module?
>
> Thanks,
>
> Bart.