linux-kernel - Re: [PATCH v2] memblock test: Modify the obsolete description in README

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YuJQgAJBxQkkooVT@kernel.org>
Date:   Thu, 28 Jul 2022 12:01:52 +0300
From:   Mike Rapoport <rppt@...nel.org>
To:     "Huang, Shaoqin" <shaoqin.huang@...el.com>
Cc:     Rebecca Mckeever <remckee0@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] memblock test: Modify the obsolete description in
 README

On Thu, Jul 28, 2022 at 01:08:25PM +0800, Huang, Shaoqin wrote:
> 
> 
> On 7/28/2022 12:05 PM, Rebecca Mckeever wrote:
> > On Wed, Jul 27, 2022 at 07:12:28PM -0600, shaoqin.huang@...el.com wrote:
> > > From: Shaoqin Huang <shaoqin.huang@...el.com>
> > > 
> > > The VERBOSE option in Makefile has been moved, but there still have the
> > > description left in README. For now, we use `-v` options when running
> > > memblock test to print information, so using the new to replace the
> > > obsolete items.
> > > 
> > Thanks for catching this!
> > 
> > > Signed-off-by: Shaoqin Huang <shaoqin.huang@...el.com>
> > > ---

...

> > >   This will print information about which functions are being tested and the
> > >   number of test cases that passed.
> > > -To simulate enabled NUMA, use:
> > > +For the full list of options from command line, see `./main --help`.
> > 
> > --help will display the list of command line options by default, but a
> > help command line option isn't explicitly implemented. I'm planning to add
> > the help option, so if you want to remove this sentence, I will add it when
> > I implement the help option.
> 
> Hi, Rebecca.
> 
> That's ok. I didn't notice the --help has not been implemented. So I can
> remove the line:
> -For the full list of options from command line, see `./main --help`.
> 
> But after remove it. There seems a little stranger about how to get the full
> list of options at the time. How do you think about it?

I '--help' option is implemented, it just does not list help for itself.
I think it's fine to keep the "For the full list..." line.
 

-- 
Sincerely yours,
Mike.