| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3dd233ff2c5a69078c9b5eb3f0263d16da128647.camel@mediatek.com>
Date: Thu, 28 Jul 2022 17:39:19 +0800
From: Rex-BC Chen <rex-bc.chen@...iatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
<chunkuang.hu@...nel.org>, <p.zabel@...gutronix.de>,
<daniel@...ll.ch>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <mripard@...nel.org>,
<tzimmermann@...e.de>, <matthias.bgg@...il.com>, <deller@....de>,
<airlied@...ux.ie>
CC: <msp@...libre.com>, <granquet@...libre.com>,
<jitao.shi@...iatek.com>, <wenst@...omium.org>,
<angelogioacchino.delregno@...labora.com>, <ck.hu@...iatek.com>,
<liangxu.xu@...iatek.com>, <dri-devel@...ts.freedesktop.org>,
<linux-mediatek@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-fbdev@...r.kernel.org>,
<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v15 01/11] dt-bindings: mediatek,dp: Add Display Port
binding
On Wed, 2022-07-27 at 09:23 +0200, Krzysztof Kozlowski wrote:
> On 27/07/2022 06:50, Bo-Chen Chen wrote:
> > From: Markus Schneider-Pargmann <msp@...libre.com>
> >
> > This controller is present on several mediatek hardware. Currently
> > mt8195 and mt8395 have this controller without a functional
> > difference,
> > so only one compatible field is added.
> >
> > The controller can have two forms, as a normal display port and as
> > an
> > embedded display port.
> >
> > Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> > Signed-off-by: Guillaume Ranquet <granquet@...libre.com>
> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@...iatek.com>
> > ---
> > .../display/mediatek/mediatek,dp.yaml | 117
> > ++++++++++++++++++
> > 1 file changed, 117 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.ya
> > ml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.ya
> > ml
> > new file mode 100644
> > index 000000000000..fd68c6c08df3
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.ya
> > ml
> > @@ -0,0 +1,117 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/display/mediatek/mediatek,dp.yaml*__;Iw!!CTRNKA9wMg0ARbw!wfsojIGZI_UYOhzgZxHy9ndUMC78GcAtJV-oZkD4DNXz0NE58uCHPE_MRZIyljEjrpwP$
> >
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!wfsojIGZI_UYOhzgZxHy9ndUMC78GcAtJV-oZkD4DNXz0NE58uCHPE_MRZIylldgseRE$
> >
> > +
> > +title: MediaTek Display Port Controller
> > +
> > +maintainers:
> > + - Chun-Kuang Hu <chunkuang.hu@...nel.org>
> > + - Jitao shi <jitao.shi@...iatek.com>
> > +
> > +description: |
> > + Device tree bindings for the MediaTek display port TX (DP) and
> > + embedded display port TX (eDP) controller present on some
> > MediaTek SoCs.
>
> Drop entire sentence and just describe the hardware.
>
> > + We just need to enable the power domain of DP. The clock of DP
> > is
> > + generated by itself and we are not using other PLL to generate
> > clocks.
> > + MediaTek DP and eDP are different hardwares and there are some
> > features
> > + which are not supported for eDP. For example, audio is not
> > supported for
> > + eDP. Therefore, we need to use two different compatibles to
> > describe them.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8195-dp-tx
> > + - mediatek,mt8195-edp-tx
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + nvmem-cells:
> > + maxItems: 1
> > + description: efuse data for display port calibration
> > +
> > + nvmem-cell-names:
> > + const: dp_calibration_data
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + ports:
> > + $ref: /schemas/graph.yaml#/properties/ports
> > + properties:
> > + port@0:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: Input endpoint of the controller, usually
> > dp_intf
> > +
> > + port@1:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + unevaluatedProperties: false
> > + description: Output endpoint of the controller
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false
> > + properties:
> > + data-lanes:
> > + description: |
> > + number of lanes supported by the hardware.
> > + The possible values:
> > + 0 - For 1 lane enabled in IP.
> > + 0 1 - For 2 lanes enabled in IP.
> > + 0 1 2 3 - For 4 lanes enabled in IP.
> > + minItems: 1
> > + maxItems: 4
> > + required:
> > + - data-lanes
> > +
> > + required:
> > + - port@0
> > + - port@1
> > +
> > + max-linkrate-mhz:
> > + enum: [ 1620, 2700, 5400, 8100 ]
> > + description: maximum link rate supported by the hardware.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - ports
> > + - max-linkrate-mhz
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/power/mt8195-power.h>
> > + dp_tx@...00000 {
>
> No underscores in node names, so just "dp".
>
> Best regards,
> Krzysztof
Hello Krzysztof,
Thanks for your review.
I will modify these in next version.
BRs,
Bo-Chen
Powered by blists - more mailing lists