linux-kernel - Re: [PATCH v2] rtc: rtc-spear: set range max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jul 2022 15:32:14 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Zeng Jingxiang <zengjx95@...il.com>
Cc:     a.zummo@...ertech.it, alexandre.belloni@...tlin.com,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zeng Jingxiang <linuszeng@...cent.com>
Subject: Re: [PATCH v2] rtc: rtc-spear: set range max

On 28-07-22, 18:01, Zeng Jingxiang wrote:
> From: Zeng Jingxiang <linuszeng@...cent.com>
> 
> In the commit f395e1d3b28d7c2c67b73bd467c4fb79523e1c65 
> ("rtc: spear: set range"), the value of 
> RTC_TIMESTAMP_END_9999 was incorrectly set to range_min.
> 390	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> 391	config->rtc->range_max = RTC_TIMESTAMP_END_9999;
> 
> Fixes: f395e1d3b28d ("rtc: spear: set range")
> Signed-off-by: Zeng Jingxiang <linuszeng@...cent.com>

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

> ---
> 
> Change in v2:
> - Add fixes tag
> 
>  drivers/rtc/rtc-spear.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
> index d4777b01ab22..736fe535cd45 100644
> --- a/drivers/rtc/rtc-spear.c
> +++ b/drivers/rtc/rtc-spear.c
> @@ -388,7 +388,7 @@ static int spear_rtc_probe(struct platform_device *pdev)
>  
>  	config->rtc->ops = &spear_rtc_ops;
>  	config->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
> -	config->rtc->range_min = RTC_TIMESTAMP_END_9999;
> +	config->rtc->range_max = RTC_TIMESTAMP_END_9999;
>  
>  	status = devm_rtc_register_device(config->rtc);
>  	if (status)
> -- 
> 2.27.0

-- 
viresh