linux-kernel - Re: [PATCH v2] ASoC: amd: acp: Initialize list to store acp_stream during pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YuJvi6IdbPyJWKUq@sirena.org.uk>
Date:   Thu, 28 Jul 2022 12:14:19 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "Prasad, Prasad" <venkataprasad.potturu@....com>
Cc:     Takashi Iwai <tiwai@...e.de>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "Reddy, V sujith kumar" <Vsujithkumar.Reddy@....com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        "Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@....com>,
        "Dommati, Sunil-kumar" <Sunil-kumar.Dommati@....com>,
        "Saba Kareem, Syed" <Syed.SabaKareem@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ASoC: amd: acp: Initialize list to store acp_stream
 during pcm_open

On Thu, Jul 28, 2022 at 07:52:25AM +0000, Prasad, Prasad wrote:

> linked to multiple pcm device as we will have same dai->driver id
> 
> or array index for multiple pcm open. Initialize new linked list
> 
> stream_list to store opened pcm stream info dynamically.
> 
> 
> 
> If an IRQ handler refers to the linked list, make sure that no list
> 
> change will happen concurrently during the IRQ handling.  It seems
> 
> that you have no protection for it yet.
> Yes, linked list may changes concurrently during IRQ handling, we will use spin locks in the next version of patch.

Please fix your mail client to clearly identify quoted text, it's very
hard to read your mails since (among other things) it's hard to tell
what text you added.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)