linux-kernel - Re: [PATCH] dt-bindings: spmi: add compatible for mt8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0d24ba1-e870-2ba0-8259-c405cb029d2f@collabora.com>
Date:   Thu, 28 Jul 2022 13:29:21 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Sen Chu <sen.chu@...iatek.com>, Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Hsin-Hsiung Wang <hsin-hsiung.wang@...iatek.com>
Cc:     Hui Liu <hui.liu@...iatek.com>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH] dt-bindings: spmi: add compatible for mt8188

Il 26/07/22 12:37, Sen Chu ha scritto:
> Add dt-binding documentation of spmi for Mediatek MT8188 SoC platform.
> 
> Signed-off-by: Sen Chu <sen.chu@...iatek.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> index 2445c5e0b0ef..05801e0199f9 100644
> --- a/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> +++ b/Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> @@ -20,6 +20,7 @@ properties:
>     compatible:
>       enum:
>         - mediatek,mt6873-spmi
> +      - mediatek,mt8188-spmi

I think that you'll be adding a SPMI node that will have:

compatible = "mediatek,mt8188-spmi", "mediatek,mt8195-spmi";

Which means that this is actually wrong, so, please fix it by
adding items...

Regards,
Angelo

>         - mediatek,mt8195-spmi
>   
>     reg:
>