linux-kernel - Re: [PATCH -next] tls: rx: Fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Jul 2022 19:05:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     borisp@...dia.com, john.fastabend@...il.com, davem@...emloft.net,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] tls: rx: Fix unsigned comparison with less than
 zero

On Thu, 28 Jul 2022 09:10:25 +0800 Yang Li wrote:
>  	struct tls_strparser *strp = (struct tls_strparser *)desc->arg.data;
> -	size_t sz, len, chunk;
> +	int sz;
> +	size_t len, chunk;
>  	struct sk_buff *skb;
>  	skb_frag_t *frag;

Thanks for the fix, please keep the sorting of the variable lines from
longest to shortest. "int sz;" should be the last variable declaration
line and "size_t len, chunk;" goes after the skb.