linux-kernel - RE: [PATCH v3] staging: fbtft: core: set smem_len before fb_deferred_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jul 2022 12:49:15 +0000
From:   "Liu, Chuansheng" <chuansheng.liu@...el.com>
To:     Peter Suti <peter.suti@...eamunlimited.com>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Javier Martinez Canillas <javierm@...hat.com>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] staging: fbtft: core: set smem_len before
 fb_deferred_io_init call

Hi Peter,

> -----Original Message-----
> From: Peter Suti <peter.suti@...eamunlimited.com>
> Sent: Wednesday, July 27, 2022 3:36 PM
> To: Liu, Chuansheng <chuansheng.liu@...el.com>; dan.carpenter@...cle.com;
> Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Thomas Zimmermann
> <tzimmermann@...e.de>; Javier Martinez Canillas <javierm@...hat.com>
> Cc: Peter Suti <peter.suti@...eamunlimited.com>; dri-
> devel@...ts.freedesktop.org; linux-fbdev@...r.kernel.org; linux-
> staging@...ts.linux.dev; linux-kernel@...r.kernel.org
> Subject: [PATCH v3] staging: fbtft: core: set smem_len before
> fb_deferred_io_init call
> 
> The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before
> initializing info->fix.smem_len.  It is set to zero by the
> framebuffer_alloc() function.  It will trigger a WARN_ON() at the
> start of fb_deferred_io_init() and the function will not do anything.

Please show us the WARN_ON() call stack, then everything is clear. It is the driver itself issue to be fixed.
I saw Thomas made such WARN_ON().

> 
> Fixes: 856082f021a2 ("fbdev: defio: fix the pagelist corruption")

Don't agree with such description.

Best Regards
Chuansheng