lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jul 2022 10:26:35 +0800 From: Stanley Chu <chu.stanley@...il.com> To: Bart Van Assche <bvanassche@....org> Cc: Stanley Chu <stanley.chu@...iatek.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, "Martin K . Petersen" <martin.petersen@...cle.com>, Avri Altman <avri.altman@....com>, alim.akhtar@...sung.com, "James E.J. Bottomley" <jejb@...ux.ibm.com>, peter.wang@...iatek.com, Chun-Hung Wu <chun-hung.wu@...iatek.com>, alice.chao@...iatek.com, powen.kao@...iatek.com, mason.zhang@...iatek.com, qilin.tan@...iatek.com, lin.gui@...iatek.com, eddie.huang@...iatek.com, tun-yu.yu@...iatek.com, cc.chou@...iatek.com, chaotian.jing@...iatek.com, jiajie.hao@...iatek.com Subject: Re: [PATCH v2 2/5] scsi: ufs: ufs-mediatek: Provide detailed description for UIC errors Hi Bart, On Thu, Jul 28, 2022 at 3:04 AM Bart Van Assche <bvanassche@....org> wrote: > > On 7/26/22 20:44, Stanley Chu wrote: > > diff --git a/drivers/ufs/host/ufs-mediatek.h b/drivers/ufs/host/ufs-mediatek.h > > index aa26d415527b..9017ab8f9867 100644 > > --- a/drivers/ufs/host/ufs-mediatek.h > > +++ b/drivers/ufs/host/ufs-mediatek.h > > @@ -26,6 +26,44 @@ > > #define REG_UFS_DEBUG_SEL_B2 0x22D8 > > #define REG_UFS_DEBUG_SEL_B3 0x22DC > > > > +/* > > + * Details of UIC Errors > > + */ > > +static const u8 *ufs_uic_err_str[] = { > > + "PHY Adapter Layer", > > + "Data Link Layer", > > + "Network Link Layer", > > + "Transport Link Layer", > > + "DME" > > +}; > > Why type u8 for strings instead of char? Will use char instead in the next version. > > Please define arrays in .c files. Otherwise one copy of the array will > be included in each source file this header file is included in. Will move them to .c in the next version. Thanks, Stanley -- Yours truly, 朱原陞 (Stanley Chu)
Powered by blists - more mailing lists