linux-kernel - Re: [PATCH v2] mm/page_owner.c: add llseek for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202207282029.T2NTavCf-lkp@intel.com>
Date:   Thu, 28 Jul 2022 20:57:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kassey Li <quic_yingangl@...cinc.com>, akpm@...ux-foundation.org,
        vbabka@...nel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org, minchan@...nel.org,
        iamjoonsoo.kim@....com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, quic_yingangl@...cinc.com
Subject: Re: [PATCH v2] mm/page_owner.c: add llseek for page_owner

Hi Kassey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220727-205617
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: arm64-randconfig-r025-20220727 (https://download.01.org/0day-ci/archive/20220728/202207282029.T2NTavCf-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 8dfaecc4c24494337933aff9d9166486ca0949f1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/5533df4120ec1703df71542154e8c5b0b21ddb10
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Kassey-Li/mm-page_owner-c-add-llseek-for-page_owner/20220727-205617
        git checkout 5533df4120ec1703df71542154e8c5b0b21ddb10
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> mm/page_owner.c:573:8: warning: no previous prototype for function 'llseek_page_owner' [-Wmissing-prototypes]
   loff_t llseek_page_owner(struct file *file, loff_t offset, int whence)
          ^
   mm/page_owner.c:573:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   loff_t llseek_page_owner(struct file *file, loff_t offset, int whence)
   ^
   static 
   1 warning generated.


vim +/llseek_page_owner +573 mm/page_owner.c

   572	
 > 573	loff_t llseek_page_owner(struct file *file, loff_t offset, int whence)
   574	{
   575		loff_t retval = 0;
   576		switch (whence) {
   577			case SEEK_CUR:
   578			case SEEK_SET:
   579				file->f_pos = offset;
   580				break;
   581			default:
   582				retval = -ENXIO;
   583		}
   584	
   585		return retval;
   586	}
   587	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp