linux-kernel - [PATCH] mux: mmio: depends on REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 27 Jul 2022 17:05:50 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        kernel test robot <lkp@...el.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Peter Rosin <peda@...ntia.se>
Subject: [PATCH] mux: mmio: depends on REGMAP

Fix build error when CONFIG_REGMAP is not set/enabled:

../drivers/mux/mmio.c: In function ‘mux_mmio_probe’:
../drivers/mux/mmio.c:76:34: error: storage size of ‘field’ isn’t known
   76 |                 struct reg_field field;
../drivers/mux/mmio.c:102:29: error: implicit declaration of function ‘devm_regmap_field_alloc’ [-Werror=implicit-function-declaration]
  102 |                 fields[i] = devm_regmap_field_alloc(dev, regmap, field);
../drivers/mux/mmio.c:76:34: warning: unused variable ‘field’ [-Wunused-variable]
   76 |                 struct reg_field field;

Most drivers that use REGMAP select it, but trying to use 'select'
here causes a ton of recursive/circular dependency chains, so just
use "depends on" to prevent the build errors.

Reported-by: kernel test robot <lkp@...el.com>
Fixes: 73726380a26f ("mux: mmio-based syscon mux controller")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Peter Rosin <peda@...ntia.se>
---
 drivers/mux/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/mux/Kconfig
+++ b/drivers/mux/Kconfig
@@ -48,6 +48,7 @@ config MUX_GPIO
 config MUX_MMIO
 	tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
 	depends on OF || COMPILE_TEST
+	depends on REGMAP
 	help
 	  MMIO/Regmap register bitfield-controlled Multiplexer controller.