[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <30ce6f21-0a91-81cb-8b03-5acff17c59ee@gmail.com>
Date: Thu, 28 Jul 2022 17:52:04 +0300
From: Markuss Broks <markuss.broks@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org,
~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
Jonathan Corbet <corbet@....net>,
Ard Biesheuvel <ardb@...nel.org>,
Jiri Slaby <jirislaby@...nel.org>,
Helge Deller <deller@....de>,
"Paul E. McKenney" <paulmck@...nel.org>,
Borislav Petkov <bp@...e.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Kees Cook <keescook@...omium.org>,
Randy Dunlap <rdunlap@...radead.org>,
Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
Javier Martinez Canillas <javierm@...hat.com>,
Michal Suchanek <msuchanek@...e.de>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Arnd Bergmann <arnd@...db.de>,
Wei Ming Chen <jj251510319013@...il.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Tony Lindgren <tony@...mide.com>, linux-doc@...r.kernel.org,
linux-efi@...r.kernel.org, linux-serial@...r.kernel.org,
linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers
and move to fbdev subsystem
Hi Greg,
On 7/28/22 17:39, Greg Kroah-Hartman wrote:
> On Thu, Jul 28, 2022 at 05:28:19PM +0300, Markuss Broks wrote:
>> Add early console support for generic linear framebuffer devices.
>> This driver supports probing from cmdline early parameters
>> or from the device-tree using information in simple-framebuffer node.
>> The EFI functionality should be retained in whole.
>> The driver was disabled on ARM because of a bug in early_ioremap
>> implementation on ARM.
>>
>> Signed-off-by: Markuss Broks <markuss.broks@...il.com>
>> ---
>> .../admin-guide/kernel-parameters.txt | 12 +-
>> MAINTAINERS | 5 +
>> drivers/firmware/efi/Kconfig | 6 +-
>> drivers/firmware/efi/Makefile | 1 -
>> drivers/firmware/efi/earlycon.c | 246 --------------
>> drivers/video/fbdev/Kconfig | 11 +
>> drivers/video/fbdev/Makefile | 1 +
>> drivers/video/fbdev/earlycon.c | 301 ++++++++++++++++++
>> 8 files changed, 327 insertions(+), 256 deletions(-)
>> delete mode 100644 drivers/firmware/efi/earlycon.c
>> create mode 100644 drivers/video/fbdev/earlycon.c
>
> That should be a rename, not a delete/create, right?
Should this change be split into two separate commits,
one for moving the file and the second for making changes?
>
> thanks,
>
> greg k-h
- Markuss
Powered by blists - more mailing lists