linux-kernel - Re: [PATCH v2 1/3] drivers: misc: intel_sysid: Add sysid from arch to drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be3f189e-c17c-2438-450d-3d84dfcd71da@linux.intel.com>
Date:   Thu, 28 Jul 2022 10:37:37 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Greg KH <gregkh@...uxfoundation.org>, kah.jing.lee@...el.com
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        rafael.j.wysocki@...el.com, tien.sung.ang@...el.com,
        dinh.nguyen@...el.com, Zhou@...ah.com,
        Furong <furong.zhou@...el.com>, Vinod Koul <vkoul@...nel.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>
Subject: Re: [PATCH v2 1/3] drivers: misc: intel_sysid: Add sysid from arch to
 drivers

Thanks for the review Greg,

>> +static int intel_sysid_probe(struct platform_device *pdev)
>> +{
>> +	struct intel_sysid *sysid;
>> +	struct resource	*regs;
>> +
>> +	sysid = devm_kzalloc(&pdev->dev, sizeof(struct intel_sysid),
>> +		GFP_KERNEL);
>> +	if (!sysid)
>> +		return -ENOMEM;
>> +
>> +	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +	if (!regs)
>> +		return -ENXIO;
>> +
>> +	sysid->regs = devm_ioremap_resource(&pdev->dev, regs);
>> +	if (IS_ERR(sysid->regs))
>> +		return PTR_ERR(sysid->regs);
>> +
>> +	platform_set_drvdata(pdev, sysid);
>> +
>> +	return devm_device_add_group(&pdev->dev, &intel_sysid_attr_group);
> 
> You just raced with userspace and lost.  Please use the default group
> for the platform device.
> 
> I need to go remove this function, it should not be used at all as it is
> broken.

Can you elaborate on the issue and suggested replacement?

We used this function for the SoundWire sysfs based on your review
comments (2 years ago?) that we should not muck with kobj, and that
function devm_device_add_group() is also used in a probe function.

Thanks!
-Pierre