linux-kernel - Re: [PATCH v5 5/6] scsi: ufs: wb: Modify messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Jul 2022 13:34:28 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     j-young.choi@...sung.com, ALIM AKHTAR <alim.akhtar@...sung.com>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 5/6] scsi: ufs: wb: Modify messages

On 7/28/22 21:57, Jinyoung CHOI wrote:
>   	ret = __ufshcd_wb_toggle(hba, enable, QUERY_FLAG_IDN_WB_EN);
>   	if (ret) {
> -		dev_err(hba->dev, "%s Write Booster %s failed %d\n",
> +		dev_err(hba->dev, "%s: Write Booster %s failed %d\n",
>   			__func__, enable ? "enable" : "disable", ret);
>   		return ret;
>   	}

Please also fix the grammar (enable -> enabling; disable -> disabling).

Otherwise this patch looks good to me.

Thanks,

Bart.