linux-kernel - Re: [PATCH v2 cgroup/for-5.20] cgroup: Replace cgroup->ancestor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YuRm8s/CFmGKYPc1@slm.duckdns.org>
Date:   Fri, 29 Jul 2022 13:02:10 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Michal Koutný <mkoutny@...e.com>
Cc:     cgroups@...r.kernel.org, Zefan Li <lizefan.x@...edance.com>,
        Christian Brauner <brauner@...nel.org>,
        linux-kernel@...r.kernel.org, kernel-team@...com,
        Namhyung Kim <namhyung@...nel.org>,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH v2 cgroup/for-5.20] cgroup: Replace
 cgroup->ancestor_ids[] with ->ancestors[]

On Sat, Jul 30, 2022 at 12:42:09AM +0200, Michal Koutný wrote:
> On Fri, Jul 29, 2022 at 10:58:22AM -1000, Tejun Heo <tj@...nel.org> wrote:
> > @@ -520,8 +520,8 @@ struct cgroup_root {
> >  	/* The root cgroup.  Root is destroyed on its release. */
> >  	struct cgroup cgrp;
> >  
> > -	/* for cgrp->ancestor_ids[0] */
> > -	u64 cgrp_ancestor_id_storage;
> > +	/* for cgrp->ancestors[0] */
> > +	u64 cgrp_ancestor_storage;
> 
> Just noticed, this member is (and was AFAICS) superfluous.

I should have changed the type to struct cgroup * but that's the space into
which cgroup_root->cgrp->ancestors[] stretch into.

Thanks.

-- 
tejun