[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220729232352.GA132527-robh@kernel.org>
Date: Fri, 29 Jul 2022 17:23:52 -0600
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: devicetree@...r.kernel.org, Christian Eggers <ceggers@...i.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Cory Tusar <cory.tusar@...1solutions.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: eeprom: at25: use
spi-peripheral-props.yaml
On Wed, 27 Jul 2022 18:44:23 +0200, Krzysztof Kozlowski wrote:
> Instead of listing directly properties typical for SPI peripherals,
> reference the spi-peripheral-props.yaml schema. This allows using all
> properties typical for SPI-connected devices, even these which device
> bindings author did not tried yet.
>
> Remove the spi-* properties which now come via spi-peripheral-props.yaml
> schema, except for the cases when device schema adds some constraints
> like maximum frequency.
>
> While changing additionalProperties->unevaluatedProperties, put it in
> typical place, just before example DTS.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> ---
>
> Technically, this depends on [1] merged to SPI tree, if we want to
> preserve existing behavior of not allowing SPI CPHA and CPOL in each of
> schemas in this patch.
>
> If this patch comes independently via different tree, the SPI CPHA and
> CPOL will be allowed for brief period of time, before [1] is merged.
> This will not have negative impact, just DT schema checks will be
> loosened for that period.
>
> [1] https://lore.kernel.org/all/20220722191539.90641-2-krzysztof.kozlowski@linaro.org/
> ---
> Documentation/devicetree/bindings/eeprom/at25.yaml | 5 ++---
> .../devicetree/bindings/misc/eeprom-93xx46.yaml | 9 ++++-----
> 2 files changed, 6 insertions(+), 8 deletions(-)
>
Applied, thanks!
Powered by blists - more mailing lists