linux-kernel - Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220729232750.8EAADC433D6@smtp.kernel.org>
Date:   Fri, 29 Jul 2022 16:27:48 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Robert Marko <robimarko@...il.com>
Cc:     Abhishek Sahu <absahu@...eaurora.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Devicetree List <devicetree@...r.kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        linux-clk@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>, tdas@...eaurora.org
Subject: Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src

Quoting Robert Marko (2022-07-11 14:14:38)
> On Mon, 11 Jul 2022 at 23:10, Stephen Boyd <sboyd@...nel.org> wrote:
> >
> > Quoting Robert Marko (2022-05-15 14:00:47)
> > > diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> > > index 3204d550ff76..42d185fe19c8 100644
> > > --- a/drivers/clk/qcom/gcc-ipq8074.c
> > > +++ b/drivers/clk/qcom/gcc-ipq8074.c
> > > @@ -663,6 +663,7 @@ static struct clk_branch gcc_sleep_clk_src = {
> > >                         },
> > >                         .num_parents = 1,
> > >                         .ops = &clk_branch2_ops,
> > > +                       .flags = CLK_IS_CRITICAL,
> > >                 },
> >
> > Why not just remove the clk from the driver? Is anything using it?
> 
> Hi Stephen, USB sleep clocks are derived from it so it cant be dropped.
> 

And we can't return NULL clks to USB for the sleep clk?